feat: export pretty-printed tactic states in ast #681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small commit, in combination with the ast parsing in mathport, together make it straightforward to produce high-quality datasets of tactic applications.
|
This could be significantly expensive. It should be controlled by a command line flag. |
digama0
reviewed
Feb 10, 2022
| auto s1 = log->get_id(summarize(before)); | ||
| auto s2 = is_eqp(before, after) ? s1 : log->get_id(summarize(after)); | ||
| auto s1 = log->get_id(before, summarize(before)); | ||
| auto s2 = is_eqp(before, after) ? s1 : log->get_id(after, summarize(after)); |
There was a problem hiding this comment.
Why not just call summarize in get_id if you are going to pass the tactic_state?
Yes, both in terms of CPU time and disk space. |
|
This is niche enough and a small enough delta that it doesn't seem worth merging into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small commit, in combination with the ast parsing in mathport, together make it straightforward to produce high-quality datasets of tactic applications.