Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(library/init/meta/interactive): give sorry tactic ignored itactic block #689

Closed
wants to merge 4 commits into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Feb 22, 2022

This supports being able to "comment out" parts of a tactic proof, which is useful during proof development when there are slow subproofs.

For example, to skip over the first subproof:

example (p : Prop) : p ↔ p :=
begin
  split,
  sorry { intro h, assumption, },
  { intro h, assumption, },
end

This supports being able to "comment out" parts of a tactic proof, which is
useful during proof development when there are slow subproofs.
@gebner
Copy link
Member

gebner commented Feb 22, 2022

Thanks!
bors r+

bors bot pushed a commit that referenced this pull request Feb 22, 2022
…tic block (#689)

This supports being able to "comment out" parts of a tactic proof, which is useful during proof development when there are slow subproofs.

For example, to skip over the first subproof:
```
example (p : Prop) : p ↔ p :=
begin
  split,
  sorry { intro h, assumption, },
  { intro h, assumption, },
end
```
@gebner
Copy link
Member

gebner commented Feb 22, 2022

bors r-

@bors
Copy link

bors bot commented Feb 22, 2022

Canceled.

@gebner
Copy link
Member

gebner commented Feb 22, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 22, 2022
…tic block (#689)

This supports being able to "comment out" parts of a tactic proof, which is useful during proof development when there are slow subproofs.

For example, to skip over the first subproof:
```
example (p : Prop) : p ↔ p :=
begin
  split,
  sorry { intro h, assumption, },
  { intro h, assumption, },
end
```
@gebner
Copy link
Member

gebner commented Feb 22, 2022

bors d+

@bors
Copy link

bors bot commented Feb 22, 2022

✌️ kmill can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented Feb 22, 2022

Canceled.

@kmill
Copy link
Contributor Author

kmill commented Feb 22, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 22, 2022
…tic block (#689)

This supports being able to "comment out" parts of a tactic proof, which is useful during proof development when there are slow subproofs.

For example, to skip over the first subproof:
```
example (p : Prop) : p ↔ p :=
begin
  split,
  sorry { intro h, assumption, },
  { intro h, assumption, },
end
```
@bors
Copy link

bors bot commented Feb 22, 2022

@bors bors bot changed the title feat(library/init/meta/interactive): give sorry tactic ignored itactic block [Merged by Bors] - feat(library/init/meta/interactive): give sorry tactic ignored itactic block Feb 22, 2022
@bors bors bot closed this Feb 22, 2022
@bors bors bot deleted the kmill_sorry_comment branch February 22, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants