[Merged by Bors] - fix(frontends/lean/builtin_cmds): add modifiers/attrs/docstring check to local command
#711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modifiers/attrs/docstring
gebner
reviewed
Apr 29, 2022
| @@ -24,6 +24,15 @@ struct cmd_meta { | |||
| cmd_meta(decl_attributes const & attrs, decl_modifiers const & mods, | |||
| optional<std::string> const & doc = optional<std::string>()): | |||
| m_attrs(attrs), m_modifiers(mods), m_doc_string(doc) {} | |||
|
|
|||
| void throw_exception_if_nonempty() const & { | |||
There was a problem hiding this comment.
I have to admit this is the first time I've come across ref-qualifiers.
There was a problem hiding this comment.
I have to admit I meant to write just const and am only barely aware of ref-qualifiers! The const & restricts throw_exception_if_nonempty to only be callable with lvalues, which is ok but a little weird.
|
Thanks! |
bors bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
… to `local` command (#711) The notation commands are supposed to reject modifiers/attrs/docstrings, but using them via the `local` command circumvents the check. This adds the check for `local` notations.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
local commandlocal command
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Jun 15, 2022
Most of the changes in this upgrade are a consequence of leanprover-community/lean#675, which removed almost all of `init/data/set.lean` from lean core so it could be migrated to mathlib. Other relevant core changes are leanprover-community/lean#714, which removed a few order decidability instances, and leanprover-community/lean#711, which caused a docstring to be rejected. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Mauricio Collares <mauricio@collares.org> Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notation commands are supposed to reject modifiers/attrs/docstrings, but using them via the
localcommand circumvents the check. This adds the check forlocalnotations.