[Merged by Bors] - fix(frontends/lean/builtin_cmds): use correct end pos for #check et al
#744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
changed the title
#check et al
|
This looks great!
|
|
bors merge |
|
Ha, this was an easy fix! |
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
#check et al#check et al
Julian
added a commit
to Julian/lean-client-js
that referenced
this pull request
Jul 16, 2022
Parallels https://github.com/leanprover/vscode-lean/blob/9a5f32602a5089fe9985df631f1b24aa44965063/src/diagnostics.ts#L67-L75 meaning we now handle the first two cases of leanprover-community/lean#744 (comment). The last one is where end_pos is undefined, and what vscode does is instead use a word range -- we can implement that from within lean.nvim. Refs: leanprover-community/lean#744
gebner
pushed a commit
to leanprover/lean-client-js
that referenced
this pull request
Jul 17, 2022
Parallels https://github.com/leanprover/vscode-lean/blob/9a5f32602a5089fe9985df631f1b24aa44965063/src/diagnostics.ts#L67-L75 meaning we now handle the first two cases of leanprover-community/lean#744 (comment). The last one is where end_pos is undefined, and what vscode does is instead use a word range -- we can implement that from within lean.nvim. Refs: leanprover-community/lean#744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on Zulip.