feat: prefix filenames with numbers, so that they are sorted correctly #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
force-pushed
the
numbered-sections
branch
from
d7b2c2a
to
c53d6a2
Compare
It was deprecated in leanprover/lake#169
The former may (and often even should) be a Python2 binary.
This is helpful when reading/browsing the book from an editor, such as VSCode.
This hopefully should break CI (because the README needs updating).
Julian
force-pushed
the
numbered-sections
branch
from
f11a049
to
380ac50
Compare
|
(My participation in the above was mostly tweaking the README to not be broken), so going to also say LGTM I think on the change itself, seems reasonable, I'd merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful when reading/browsing the book from an editor, such as VSCode.