update contribute/style #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgouezel
commented
Jan 3, 2021
sgouezel
commented
Jan 3, 2021
|
These changes look great to me. In particular the comment that lower case greek letters should be used for "generic types" (but sensible maths capital letters can be used for sensible maths objects) is long overdue and I think fits very well with what is happening right now (and is also a good system!) |
|
LGTM. |
sgouezel
commented
Jan 3, 2021
bryangingechen
approved these changes
Jan 3, 2021
|
As mentioned in the Zulip thread, I would prefer to not have the convention "a single tactic invocation per line". The rest LGTM. |
urkud
reviewed
Jan 4, 2021
|
Should we change "We generally restrict the use of dots to inductive types." in |
|
I have also made a few changes to |
Vierkantor
approved these changes
Jan 4, 2021
fpvandoorn
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a discussion with @fpvandoorn at leanprover-community/mathlib#5414 (comment), I have the impression that the style guide does not completely reflect our current style. I propose some modifications in the current PR based on my feeling of what these practices are. Feedback/improvements/clarifications are most welcome!