-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pipx for installation of mathlibtools #77
Conversation
I'd have mentioned what
|
Good point. I've added this and also took the liberty to slightly homogenize the different guides. |
templates/install/windows.md
Outdated
```bash | ||
python3 -m pip install --user pipx | ||
python3 -m pipx ensurepath | ||
pipx install mathlibtools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, this doesn't work. I just followed the instructions on a fresh Windows 10 machine, and upon getting to this step pipx install mathlibtools
just says bash: pipx: command not found
.
I closed and restarted "git bash", and get the same message. I rebooted the windows machine (I have not yet tried unplugging the router...) and get the same message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for testing this. I'm looking into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pipx
is known to work on Windows, so the question is about what goes wrong in your environment. Something semi-trivial with PATH, I suppose. Hard to tell without a Windows box (or at least a VM) in front of me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first problem is that pipx ensurepath
modifies the Windows PATH
variable, but we want to modify the git bash
PATH
, which is different.
After manually setting the path, there was also some venv
problem, which can probably be fixed, but I didn't try very hard.
Despite |
@TwoFX am I correct in thinking that instructions in this PR now match what is done by the automatic scripts, hence work? Could you have a look at the git conflict? |
Yes the instructions match.
I merged; is the conflict resolved? |
Actually, the conflicts were due to the complicated git history. The end result was not conflicting, so I squashed. Thanks again for looking into all this. |
This is my attempt at the most likely abandoned #74, trying to address the fact that using
sudo pip3 install
seems to be discouraged (cf. this comment). The easiest way of installing end-user software from PyPI that follows "best practices" that I am aware of ispipx
, which in particular has a commandensurepath
that does all thePATH
fiddling (which is not necessary when usingsudo
, but is necessary when using--user
) automatically. This PR changes the instructions to follow this route.