Update Lean and Mathlib to the port-complete tag #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
port-complete
branch
from
982f1ef
to
9218efa
Compare
eric-wieser
force-pushed
the
port-complete
branch
from
adca715
to
cb462b8
Compare
eric-wieser
commented
Oct 23, 2023
| @@ -521,11 +521,11 @@ to use the library | |||
| section you_should_probably_skip_this | |||
|
|
|||
| /- If `M` is a manifold modelled on a vector space `E`, then the underlying type for the tangent | |||
| bundle is just `Σ (x : M), tangent_space x M` (i.e., the disjoint union of the tangent spaces, | |||
| bundle is effectively `Σ (x : M), tangent_space x M` (i.e., the disjoint union of the tangent spaces, | |||
There was a problem hiding this comment.
@fpvandoorn, do you think this needs slightly more care, or is this comment fine?
There was a problem hiding this comment.
This has changed since LFTCM 2020, and I think this change is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need some small fixes