This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix: various improvements to get-cache #113
Merged
eric-wieser
merged 12 commits into
leanprover-community:master
from
eric-wieser:fix-get-cache-non-mathlib
Sep 17, 2021
Merged
fix: various improvements to get-cache #113
eric-wieser
merged 12 commits into
leanprover-community:master
from
eric-wieser:fix-get-cache-non-mathlib
Sep 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
changed the title
Use the new cache-searching logic in non-mathlib project too
fix: various improvements to get-cache
Aug 22, 2021
jcommelin
reviewed
Sep 9, 2021
…t-cache as it doesn't really protect against anything.
eric-wieser
commented
Sep 17, 2021
jcommelin
reviewed
Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the size of this PR; my impression was that the semantics of some of the commands were mixed up, and it was easier to change them all at once
Before this PR
leanproject mk-cache --force
on a dirty tree:HEAD
that represents the dirty state of the working tree (which is not HEAD!)leanproject get-cache
mk-cache
it contains all the lean source files too.get-cache --rev old_revision
acts much likegit checkout old_revision -- .
leanproject get-mathlib-cache
leanproject get-cache
git reset
on mathlibAfter this PR
leanproject mk-cache --force
on a dirty tree:--force
is now only for overwriting the cache if it existsleanproject get-cache
on any project:--force
. It only made sense in the presence of the destructive behavior regarding .lean files, which is no longer present.leanproject get-mathlib-cache
--rev
leanproject get-cache
, spits out a warning telling the user to useget-cache
directly.git reset
on mathlib, then applying lean files from the tarball.This replaces #96