Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Creates a python package #12

Merged
merged 7 commits into from Feb 18, 2020

Conversation

PatrickMassot
Copy link
Member

It includes cache-olean, update-mathlib and setup-lean-git-hooks.

Please review but do not merge yet. Merging this will require coordination with mathlib documentation update.

It includes cache-olean, update-mathlib and setup-lean-git-hooks.
@cipher1024
Copy link
Contributor

What does the installation line become?

@PatrickMassot
Copy link
Member Author

The installation line would be pip install mathlibtools (or the same with --user or sudo depending on the local setup).

@gebner
Copy link
Member

gebner commented Feb 18, 2020

The scripts/install_debian.sh file still needs to be updated. Unfortunately, I can't push updates to this branch.

@PatrickMassot
Copy link
Member Author

@gebner can you try to push to https://github.com/leanprover-community/mathlib-tools/tree/package? If this work we can close this PR and reopen from there (unless someone knows how to switch the PR branch origin).

@gebner
Copy link
Member

gebner commented Feb 18, 2020

Oh, apparently I can push to this branch as well. Sorry for bothering you.

@PatrickMassot
Copy link
Member Author

This is super weird. Does anyone have any idea how Gabriel hacked my repo?

@gebner
Copy link
Member

gebner commented Feb 18, 2020

@PatrickMassot There is an "allow edits from maintainers" button that is automatically checked when creating a PR: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Apparently I'm a mathlib-tools maintainer. 🤷‍♂️

@gebner
Copy link
Member

gebner commented Feb 18, 2020

The CI checks only fail due to github API rate limits now.

@gebner gebner added enhancement New feature or request and removed WIP labels Feb 18, 2020
@cipher1024
Copy link
Contributor

The solutions to this is use a GitHub token to query GitHub and only work on PRs on this repo (no forks)

@gebner
Copy link
Member

gebner commented Feb 18, 2020

@cipher1024 I thought this is what GITHUB_CRED is for, but it doesn't seem to be set on PRs. I'm not sure if it's possible to enable the secret for all PRs in travis.

@cipher1024 cipher1024 merged commit 79a9fb3 into leanprover-community:master Feb 18, 2020
@cipher1024
Copy link
Contributor

I didn't notice, it's on Patrick's repo. That's why the tokens aren't being used.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants