Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Remove use of deprecated logging methods. #121

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Remove use of deprecated logging methods. #121

merged 1 commit into from
Jan 5, 2022

Conversation

Julian
Copy link
Contributor

@Julian Julian commented Jan 5, 2022

Logger.warn is spelled Logger.warning.

Logger.warn is spelled Logger.warning.
@PatrickMassot
Copy link
Member

Do you have references about this deprecation? Which python versions use the new spelling?

@Julian
Copy link
Contributor Author

Julian commented Jan 5, 2022

Sorry, I was lazy -- logger.warn was deprecated for 10 years or so at least, it's from before the module was incorporated into the standard library:

⊙  python3 -W default -c 'import logging; logging.getLogger().warn("Hello")'                                                                                                        julian@Airm
<string>:1: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
Hello

See e.g. https://bugs.python.org/issue13235 -- which looks like it says it was deprecated at least back since 3.3.

@PatrickMassot PatrickMassot merged commit bdae7e9 into leanprover-community:master Jan 5, 2022
@PatrickMassot
Copy link
Member

Thanks

@Julian Julian deleted the remove-deprecated-logging-calls branch January 5, 2022 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants