Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Commit

Permalink
chore(ring_theory): split finiteness into finite, finite type and fin…
Browse files Browse the repository at this point in the history
…ite presentation (#17481)

`module.finite` is used in a lot of places (especially in the form of `finite_dimensional`) but it is defined alongside `algebra.finite_type` and `algebra.finite_presentation`, so it brings a lot of dependencies with it. By splitting the file along the lines of the three definitions we should be able to clean up the import graph noticeably. In particular, finite dimensional vector spaces shouldn't know about (`mv_`)polynomials anymore.
  • Loading branch information
Vierkantor committed Nov 15, 2022
1 parent 597343b commit 6e7ca69
Show file tree
Hide file tree
Showing 11 changed files with 1,112 additions and 958 deletions.
2 changes: 1 addition & 1 deletion src/data/polynomial/module.lean
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
Authors: Andrew Yang
-/

import ring_theory.finiteness
import ring_theory.finite_type

/-!
# Polynomial module
Expand Down
1 change: 1 addition & 0 deletions src/linear_algebra/finite_dimensional.lean
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Authors: Chris Hughes
import algebra.algebra.subalgebra.basic
import field_theory.finiteness
import linear_algebra.finrank
import tactic.interval_cases

/-!
# Finite dimensional vector spaces
Expand Down
2 changes: 2 additions & 0 deletions src/ring_theory/adjoin_root.lean
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import algebra.algebra.basic
import data.polynomial.field_division
import linear_algebra.finite_dimensional
import ring_theory.adjoin.basic
import ring_theory.finite_presentation
import ring_theory.finite_type
import ring_theory.power_basis
import ring_theory.principal_ideal_domain

Expand Down
454 changes: 454 additions & 0 deletions src/ring_theory/finite_presentation.lean

Large diffs are not rendered by default.

Loading

0 comments on commit 6e7ca69

Please sign in to comment.