[Merged by Bors] - feat(data/nat/basic): Add two lemmas two nat/basic which are necessary for the count PR #10001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
reviewed
Oct 27, 2021
src/data/nat/basic.lean
Outdated
Comment on lines
111
to
112
| lemma nat.subtype.semilattice_sup_bot_bot_apply {s : set ℕ} [decidable_pred (∈ s)] | ||
| [h : nonempty s] : ((⊥ : s) : ℕ) = nat.find (nonempty_subtype.1 h) := rfl |
There was a problem hiding this comment.
Perhaps reverse the sides and make it a @[simp] lemma?
There was a problem hiding this comment.
Well, nat.Inf is defined in terms of nat.find - do we really want to simplify nat.find into a bottom element? I assumed nat.find is a more basic concept.
There was a problem hiding this comment.
I think I agree with @SymmetryUnbroken, I think the lemma is better this way around.
|
bors d+ |
|
✌️ SymmetryUnbroken can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
…y for the count PR (#10001) Add two lemmas proved by refl to data/nat/basic. They are needed for the count PR, and are changing a file low enogh in the import hierarchy to be a separate PR.
eric-wieser
reviewed
Oct 27, 2021
eric-wieser
reviewed
Oct 27, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Canceled. |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
…y for the count PR (#10001) Add two lemmas proved by refl to data/nat/basic. They are needed for the count PR, and are changing a file low enogh in the import hierarchy to be a separate PR. Co-authored-by: SymmetryUnbroken <64909175+SymmetryUnbroken@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
…y for the count PR (#10001) Add two lemmas proved by refl to data/nat/basic. They are needed for the count PR, and are changing a file low enogh in the import hierarchy to be a separate PR. Co-authored-by: SymmetryUnbroken <64909175+SymmetryUnbroken@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two lemmas proved by refl to data/nat/basic. They are needed for the count PR, and are changing a file low enogh in the import hierarchy to be a separate PR.