Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/convex/[basic, topology]): generalize path connectedness of convex sets to topological real vector spaces #10011

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(analysis/convex/[basic, topology]): generalize path connectedness of convex sets to topological real vector spaces #10011

wants to merge 3 commits into from

Conversation

ADedecker
Copy link
Member

Open in Gitpod

@ADedecker ADedecker added the awaiting-review The author would like community review of the PR label Oct 27, 2021
@sgouezel
Copy link
Collaborator

The linter is not happy. Do you understand what is going on?

@ADedecker
Copy link
Member Author

First, sorry for the late response.

I'm not sure what precisely goes wrong, but what I understand is that Lean tries a lot of things to prove that a product type is nonempty without the assumption that each factor is. One of them is trying to prove path connectedness, and somehow generalizing this instance makes the search significantly slower. So I guess the fix would be to lower a priority somewhere, but I have no idea where exactly.

@ADedecker
Copy link
Member Author

As suggested here, I increased the acceptable limit for the fails_quickly linter so that it doesn't complain anymore.

jcommelin
jcommelin approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 3, 2021
bors bot pushed a commit that referenced this pull request Dec 3, 2021
@ADedecker
feat(analysis/convex/[basic, topology]): generalize path connectednes…
2bb627f 
…s of convex sets to topological real vector spaces (#10011)
@bors
Copy link

bors bot commented Dec 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/convex/[basic, topology]): generalize path connectedness of convex sets to topological real vector spaces [Merged by Bors] - feat(analysis/convex/[basic, topology]): generalize path connectedness of convex sets to topological real vector spaces Dec 3, 2021
@bors bors bot closed this Dec 3, 2021
@bors bors bot deleted the convex_topological_vect branch December 3, 2021 08:57
jcommelin pushed a commit that referenced this pull request Dec 18, 2021
@ADedecker @jcommelin
feat(analysis/convex/[basic, topology]): generalize path connectednes…
ba97f4b 
…s of convex sets to topological real vector spaces (#10011)
@gebner gebner mentioned this pull request Mar 14, 2022
Closed
bors bot pushed a commit that referenced this pull request Mar 15, 2022
@gebner
perf(analysis/convec/topology): remove topological_add_group.path_con…
eefa425 
…nected instance (#12675)

The linter was right in #10011 and `topological_add_group.path_connected` should not be an instance, because it creates enormous TC subproblems (turn on `pp.all` to get an idea of what's going on).

Apparently the instance isn't even used in mathlib.
laurentbartholdi pushed a commit that referenced this pull request Mar 17, 2022
@gebner @laurentbartholdi
perf(analysis/convec/topology): remove topological_add_group.path_con…
c2ed8c9 
…nected instance (#12675)

The linter was right in #10011 and `topological_add_group.path_connected` should not be an instance, because it creates enormous TC subproblems (turn on `pp.all` to get an idea of what's going on).

Apparently the instance isn't even used in mathlib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ADedecker @sgouezel @jcommelin