This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
[Merged by Bors] - fix(field_theory/intermediate_field): use a better algebra.smul
definition, and generalize
#10012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inition, and generalize Previously coe_smul was not true by `rfl`
eric-wieser
force-pushed
the
eric-wieser/fix-intermediate_field.lift2_alg
branch
from
October 27, 2021 22:47
7ac033b
to
3a28b09
Compare
eric-wieser
commented
Oct 27, 2021
kbuzzard
reviewed
Oct 27, 2021
instance module' {R} [semiring R] [has_scalar R K] [module R L] [is_scalar_tower R K L] : | ||
module R S := | ||
S.to_subalgebra.module' | ||
instance module : module K S := S.to_subalgebra.module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline?
Suggested change
instance module : module K S := S.to_subalgebra.module | |
instance module : module K S := S.to_subalgebra.module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eric-wieser
commented
Oct 27, 2021
rw [trace_algebra_map, ← is_scalar_tower.algebra_map_smul K, (algebra.trace K K⟮x⟯).map_smul, | ||
smul_eq_mul, algebra.smul_def], | ||
apply_instance | ||
rw [trace_algebra_map, linear_map.map_smul_of_tower], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain why this proof broke, but this new proof is better anyway.
eric-wieser
commented
Oct 28, 2021
eric-wieser
added
the
awaiting-review
The author would like community review of the PR
label
Oct 28, 2021
jcommelin
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 28, 2021
bors bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
…inition, and generalize (#10012) Previously coe_smul was not true by `rfl`
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
fix(field_theory/intermediate_field): use a better
[Merged by Bors] - fix(field_theory/intermediate_field): use a better Oct 28, 2021
algebra.smul
definition, and generalizealgebra.smul
definition, and generalize
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
…inition, and generalize (#10012) Previously coe_smul was not true by `rfl`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously coe_smul was not true by
rfl