[Merged by Bors] - feat(linear_algebra/basic): some lemmas about span and restrict_scalars #10167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eric-wieser
commented
Nov 4, 2021
eric-wieser
commented
eric-wieser
added
awaiting-review
eric-wieser
commented
Nov 4, 2021
eric-wieser
commented
Nov 4, 2021
eric-wieser
force-pushed
the
eric-wieser/span-tower
branch
from
00c986b
to
20a4181
Compare
eric-wieser
commented
Nov 5, 2021
github-actions
bot
removed
the
awaiting-CI
ocfnash
reviewed
Nov 8, 2021
| @@ -800,9 +801,15 @@ span_le.2 $ subset.trans h subset_span | |||
| lemma span_eq_of_le (h₁ : s ⊆ p) (h₂ : p ≤ span R s) : span R s = p := | |||
| le_antisymm (span_le.2 h₁) h₂ | |||
|
|
|||
| @[simp] lemma span_eq : span R (p : set M) = p := | |||
| lemma span_eq : span R (p : set M) = p := | |||
There was a problem hiding this comment.
I'm quite surprised to see simp being removed here. Is there an easy explanation of why we shouldn't keep it?
There was a problem hiding this comment.
Yes, the linter complains! This is now proved via the new lemma
|
I'd like to understand the reason for dropping the bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge See above, the linter forced my hand. |
github-actions
bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.