Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(combinatorics/set_family/shadow): Shadow of a set family #10223

Closed
wants to merge 9 commits into from

Conversation

YaelDillies
Copy link
Collaborator

This defines shadow 𝒜 where 𝒜 : finset (finset α)).


The shadow of a set family is its projection (hence the name) down the membership hypercube. Combinatorics of set families are interested in the size of shadows and ways to make it smaller (through so-called compressions).

Co-authored-by: Bhavik Mehta bhavikmehta8@gmail.com, Alena Gusakov @agusakov

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Nov 8, 2021
src/combinatorics/set_family/shadow.lean Outdated Show resolved Hide resolved
src/combinatorics/set_family/shadow.lean Outdated Show resolved Hide resolved
src/combinatorics/set_family/shadow.lean Outdated Show resolved Hide resolved

## Notation

`∂ 𝒜` is notation for `shadow 𝒜`. It is situated in locale `finset_family`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the mathscr unicode A through this file for finset families to match my notes (I was very new to Lean when the first version of this file was made), perhaps more sensible choices should be considered?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like that choice. In general, your branch was very nice-looking notation-wise, but the notation was pretty obscure. Another idea would be to use s and t for the finsets and A for the family.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah s and t for the finsets would match nicely with data/finset as well

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to adjust to A, B : finset (finset α) before merging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quite like it like that. But I can change if you really want to.

@YaelDillies YaelDillies added this to In progress in Graph Theory and Combinatorics via automation Nov 9, 2021
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
YaelDillies and others added 2 commits November 13, 2021 09:53
Co-authored-by: David Wärn <codwarn@gmail.com>
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

bors d+

src/combinatorics/set_family/shadow.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Nov 15, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 15, 2021
@YaelDillies
Copy link
Collaborator Author

One more down!

bors merge

bors bot pushed a commit that referenced this pull request Nov 16, 2021
This defines `shadow 𝒜` where `𝒜 : finset (finset α))`.
@bors
Copy link

bors bot commented Nov 17, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(combinatorics/set_family/shadow): Shadow of a set family [Merged by Bors] - feat(combinatorics/set_family/shadow): Shadow of a set family Nov 17, 2021
@bors bors bot closed this Nov 17, 2021
Graph Theory and Combinatorics automation moved this from In progress to Done Nov 17, 2021
@bors bors bot deleted the shadow branch November 17, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Development

Successfully merging this pull request may close these issues.

None yet

6 participants