Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory/constructions/{pi,prod}): drop some measurability assumptions #10241

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(measure_theory/constructions/{pi,prod}): drop some measurability assumptions #10241

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 9, 2021

Some lemmas (most notably prod_prod and pi_pi) are true for non-measurable sets as well.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Nov 9, 2021
@fpvandoorn
Copy link
Member

This is great, and simplifies a lot!
I will do a more detailed review once mathlib builds.

@fpvandoorn fpvandoorn added the awaiting-author A reviewer has asked the author a question or requested changes label Nov 9, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 9, 2021
@fpvandoorn
Copy link
Member

Looks great. Very nifty proof. I'm still not quite sure I understand why we use (to_measurable μ s).prod (to_measurable ν t) in one direction and to_measurable (μ.prod ν) (s.prod t) in the other direction.

bors d+

@bors
Copy link

bors bot commented Nov 9, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 9, 2021
@fpvandoorn
Copy link
Member

Oh, linting just succeeded.

bors merge

@fpvandoorn fpvandoorn removed the awaiting-author A reviewer has asked the author a question or requested changes label Nov 9, 2021
@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 9, 2021
@bryangingechen
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request Nov 10, 2021
@urkud
feat(measure_theory/constructions/{pi,prod}): drop some measurability…
bb62b8e 
… assumptions (#10241)

Some lemmas (most notably `prod_prod` and `pi_pi`) are true for non-measurable sets as well.
@sgouezel
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request Nov 10, 2021
@urkud
feat(measure_theory/constructions/{pi,prod}): drop some measurability…
bbbefe4 
… assumptions (#10241)

Some lemmas (most notably `prod_prod` and `pi_pi`) are true for non-measurable sets as well.
@bors
Copy link

bors bot commented Nov 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/constructions/{pi,prod}): drop some measurability assumptions [Merged by Bors] - feat(measure_theory/constructions/{pi,prod}): drop some measurability assumptions Nov 10, 2021
@bors bors bot closed this Nov 10, 2021
@bors bors bot deleted the YK-Fubini-set branch November 10, 2021 16:25
@fpvandoorn
Copy link
Member

third time's a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn Awaiting requested review from fpvandoorn

@sgouezel sgouezel Awaiting requested review from sgouezel

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @fpvandoorn @bryangingechen @sgouezel