Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(linear_algebra/pi_tensor_product): add subsingleton_equiv #10274

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

This is useful for constructing the tensor product of a single module, which we will ultimately need to show an isomorphism to tensor_algebra.

This also refactors pempty_equiv to use is_empty, which probably didn't exist at the time. This eliminates a surprising universe variable that was parameterizing pempty.


Open in Gitpod

This is useful for constructing the tensor product of a single module, which we will ultimately need to show an isomorphism to `tensor_algebra`.

This also refactors `pempty_equiv` to use `is_empty`, which probably didn't exist at the time.
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Nov 11, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 11, 2021
bors bot pushed a commit that referenced this pull request Nov 11, 2021
This is useful for constructing the tensor product of a single module, which we will ultimately need to show an isomorphism to `tensor_algebra`.

This also refactors `pempty_equiv` to use `is_empty`, which probably didn't exist at the time. This eliminates a surprising universe variable that was parameterizing `pempty`.
@bors
Copy link

bors bot commented Nov 11, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/pi_tensor_product): add subsingleton_equiv [Merged by Bors] - feat(linear_algebra/pi_tensor_product): add subsingleton_equiv Nov 11, 2021
@bors bors bot closed this Nov 11, 2021
@bors bors bot deleted the eric-wieser/pi_tensor_product.unique branch November 11, 2021 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants