[Merged by Bors] - fix(data/finsupp/basic): add missing decidable argument #10649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `finsupp.erase` is classical and requires no decidability, `finset.erase` is not so. Without this argument, this lemma does not apply in the general case, and introduces mismatching decidable instances.
eric-wieser
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
|
Thanks! |
github-actions
bot
added
ready-to-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
While `finsupp.erase` is classical and requires no decidability, `finset.erase` is not so. Without this argument, this lemma does not apply in the general case, and introduces mismatching decidable instances. With it, a `congr` is no longer needed elsewhere in mathlib.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
While `finsupp.erase` is classical and requires no decidability, `finset.erase` is not so. Without this argument, this lemma does not apply in the general case, and introduces mismatching decidable instances. With it, a `congr` is no longer needed elsewhere in mathlib.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
finsupp.eraseis classical and requires no decidability,finset.eraseis not so.Without this argument, this lemma does not apply in the general case, and introduces mismatching decidable instances. With it, a
congris no longer needed elsewhere in mathlib.