Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/equiv/basic): lemmas about composition with equivalences #10693

Closed
wants to merge 16 commits into from
Closed

[Merged by Bors] - feat(data/equiv/basic): lemmas about composition with equivalences #10693

wants to merge 16 commits into from

Conversation

antoinelab01
Copy link
Collaborator

Open in Gitpod

antoinelab01 and others added 3 commits December 9, 2021 14:13
@antoinelab01 @eric-wieser
Update src/data/equiv/mul_add.lean
72405b6 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@antoinelab01 @eric-wieser
Update src/data/equiv/basic.lean
f50108b 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@antoinelab01
.
95d13ae
@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 10, 2021
@antoinelab01 @eric-wieser
Update src/data/equiv/mul_add.lean
b3d5ed1 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@antoinelab01 antoinelab01 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 12, 2021
@antoinelab01
Copy link
Collaborator Author

I think I fixed all the errors, but for some reason the linter is still unhappy

eric-wieser
eric-wieser reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd to me that linear_equiv.eq_comp_symm is about linear_map.comp, but mul_equiv.eq_comp_symm is not about monoid_hom.comp (and instead is about function.comp like equiv.eq_comp_symm).

I think we should probably rename the lemmas about linear_map.comp from eq_comp_symm to eq_comp_to_linear_map_symm, which frees up the existing names to hold the lemmas about function.comp.

@antoinelab01
Copy link
Collaborator Author

It seems odd to me that linear_equiv.eq_comp_symm is about linear_map.comp, but mul_equiv.eq_comp_symm is not about monoid_hom.comp (and instead is about function.comp like equiv.eq_comp_symm).

I think we should probably rename the lemmas about linear_map.comp from eq_comp_symm to eq_comp_to_linear_map_symm, which frees up the existing names to hold the lemmas about function.comp.

Done!

@eric-wieser
Copy link
Member

Thanks! Can you add the function.comp version of the lemmas for linear_equiv too? You should be able to just copy the proofs you used for mul_equiv.

@antoinelab01
Copy link
Collaborator Author

Thanks! Can you add the function.comp version of the lemmas for linear_equiv too? You should be able to just copy the proofs you used for mul_equiv.

Done!

@antoinelab01
Copy link
Collaborator Author

@eric-wieser This PR got kind of forgotten, any chance it could be merged soon? (or let me know if it still needs changes)

eric-wieser
eric-wieser approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Just a small style comment to address

@bors
Copy link

bors bot commented Mar 7, 2022

✌️ antoinelab01 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the delegated The PR author may merge after reviewing final suggestions. label Mar 7, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the awaiting-review The author would like community review of the PR label Mar 7, 2022
@eric-wieser
Copy link
Member

Since this has sat around for a while, can you make sure to merge master and wait for CI before merging?

@eric-wieser eric-wieser added the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 7, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 8, 2022
@antoinelab01
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Mar 8, 2022
@antoinelab01 @eric-wieser
feat(data/equiv/basic): lemmas about composition with equivalences (#…
11a2bf3 
…10693)




Co-authored-by: antoinelab01 <66086247+antoinelab01@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Mar 9, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 9, 2022
@antoinelab01 @eric-wieser
feat(data/equiv/basic): lemmas about composition with equivalences (#…
2a3ecad 
…10693)




Co-authored-by: antoinelab01 <66086247+antoinelab01@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Mar 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/equiv/basic): lemmas about composition with equivalences [Merged by Bors] - feat(data/equiv/basic): lemmas about composition with equivalences Mar 9, 2022
@bors bors bot closed this Mar 9, 2022
@bors bors bot deleted the equiv_lemmas branch March 9, 2022 02:37
@antoinelab01 antoinelab01 mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antoinelab01 @eric-wieser @leanprover-community-bot-assistant