Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/gcd_monoid): associates lemmas #10705

Closed
wants to merge 6 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Dec 10, 2021


Open in Gitpod

I'm really quite bad with quotients... I'd appreciate a golf if anyone knows how to write them better!

@ericrbg ericrbg added the awaiting-review The author would like community review of the PR label Dec 10, 2021
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Dec 10, 2021

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 10, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@ericrbg ericrbg added the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 10, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 10, 2021
@ericrbg
Copy link
Collaborator Author

ericrbg commented Dec 10, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 10, 2021


Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/gcd_monoid): associates lemmas [Merged by Bors] - feat(algebra/gcd_monoid): associates lemmas Dec 10, 2021
@bors bors bot closed this Dec 10, 2021
@bors bors bot deleted the ericrbg/associates_lemmas branch December 10, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants