Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data/finset/grade): Finsets and multisets are graded #10865

Closed
wants to merge 12 commits into from
Closed

feat(data/finset/grade): Finsets and multisets are graded #10865

wants to merge 12 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Dec 18, 2021 •
edited

Characterise is_atom, is_coatom, covby in set α, multiset α, finset α and deduce that multiset α, finset α are graded orders.

Open in Gitpod

@YaelDillies YaelDillies added the WIP Work in progress label Dec 18, 2021
@YaelDillies YaelDillies mentioned this pull request Dec 18, 2021
Closed
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 18, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 24, 2021
@b-mehta
Copy link
Collaborator

b-mehta commented Jan 21, 2022

Provided you have the time, may I bump this? I think this is something we really ought to have in mathlib!

@YaelDillies
Copy link
Collaborator Author

Yes, but I must warn you that @astOwOlfo already has the more general statement that if s covers t, then s is insert a t for some a on branch polytopes.

@b-mehta
Copy link
Collaborator

b-mehta commented Jan 21, 2022

Even then, this special case is valuable. Can we try to get either that version, or this version in?

@YaelDillies
Copy link
Collaborator Author

Yup! Will do that when I have time again, aka in a week or two (I hope!).

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 9, 2022
@YaelDillies
Copy link
Collaborator Author

Yup! Will do that when I have time again, aka in a week or two (I hope!).

Famous last words 🙃

@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Jun 9, 2023
@YaelDillies YaelDillies changed the title feat(order/atoms): A set/finset/multiset is an atom iff it's a singleton feat(data/finset/grade): Finsets and multisets are graded Jun 10, 2023
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-order Order hierarchy and removed WIP Work in progress merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Jun 10, 2023
@eric-wieser eric-wieser added the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Jul 15, 2023
@YaelDillies
Copy link
Collaborator Author

Ported as leanprover-community/mathlib4#8892.

@YaelDillies YaelDillies closed this Dec 8, 2023
@YaelDillies YaelDillies deleted the is_atom_set branch December 8, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @b-mehta @eric-wieser @leanprover-community-bot-assistant