Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topology/order): pasting lemmas #1110

Closed
wants to merge 5 commits into from
Closed

Conversation

ChrisHughes24
Copy link
Member

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@ChrisHughes24 ChrisHughes24 requested a review from a team as a code owner June 3, 2019 22:27
@rwbarton
Copy link
Collaborator

rwbarton commented Jun 3, 2019

The two main gluing lemmas are pretty similar to continuous_subtype_nhds_cover and continuous_subtype_is_closed_cover. Does it make sense to merge these or at least reuse the proofs somehow?

src/topology/order.lean Outdated Show resolved Hide resolved
src/topology/order.lean Outdated Show resolved Hide resolved
ChrisHughes24 and others added 2 commits June 4, 2019 12:15
Co-Authored-By: Johan Commelin <johan@commelin.net>
Co-Authored-By: Johan Commelin <johan@commelin.net>
@ChrisHughes24
Copy link
Member Author

The two main gluing lemmas are pretty similar to continuous_subtype_nhds_cover and continuous_subtype_is_closed_cover. Does it make sense to merge these or at least reuse the proofs somehow?

I didn't realise there was any version of this lemma in mathlib. I don't have any particular reason to prefer my statement, I think the best thing is to close this PR, and just add some docstring on those lemmas containing gluing so people can find it more easily.

@rwbarton
Copy link
Collaborator

rwbarton commented Jun 4, 2019

Ah, OK. Sounds good to me.

@ChrisHughes24 ChrisHughes24 deleted the pasting_lemma branch June 26, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants