Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/sup_indep): More lemmas #11932

Closed
wants to merge 13 commits into from

Conversation

YaelDillies
Copy link
Collaborator

A few more lemmas about finset.sup_indep and set.pairwise_disjoint.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Feb 9, 2022
@b-mehta b-mehta added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 11, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 21, 2022
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest making all the f's of type ι × ι' → α (and maybe the one in sup_indep.sigma explicit)

src/order/sup_indep.lean Show resolved Hide resolved
src/order/sup_indep.lean Show resolved Hide resolved
src/order/sup_indep.lean Outdated Show resolved Hide resolved
@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 23, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 4, 2022
Comment on lines 374 to 378
lemma pairwise_disjoint.prod {f : ι → set α} {g : κ → set β} (hs : s.pairwise_disjoint f)
(ht : t.pairwise_disjoint g) :
(s ×ˢ t : set (ι × κ)).pairwise_disjoint (λ i, (f i.1) ×ˢ (g i.2)) :=
λ ⟨i, i'⟩ ⟨hi, hi'⟩ ⟨j, j'⟩ ⟨hj, hj'⟩ hij ⟨a, b⟩ ⟨⟨hai, hbi⟩, haj, hbj⟩,
hij $ prod.ext (hs.elim_set hi hj _ hai haj) $ ht.elim_set hi' hj' _ hbi hbj
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels weird to have the pairwise_disjoint vesion of this before the disjoint version. Here's one disjoint version:

lemma disjoint.prod_left {α β : Type*} {f₁ f₂ : set α} (hf : disjoint f₁ f₂) (g₁ g₂ : set β) :
  disjoint (f₁ ×ˢ g₁) (f₂ ×ˢ g₂) :=
λ ⟨a, b⟩ ⟨⟨ha₁, hb₁⟩, ⟨ha₂, hb₂⟩⟩, hf ⟨ha₁, ha₂⟩

lemma disjoint.prod_right {α β : Type*} (f₁ f₂ : set α) {g₁ g₂ : set β} (hg : disjoint g₁ g₂) :
  disjoint (f₁ ×ˢ g₁) (f₂ ×ˢ g₂) :=
λ ⟨a, b⟩ ⟨⟨ha₁, hb₁⟩, ⟨ha₂, hb₂⟩⟩, hg ⟨hb₁, hb₂⟩

I'll let you think about what the analogous one for prod' is.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but it doesn't seem to golf anything down.

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 10, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 11, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 11, 2022
@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Jun 9, 2023
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-order Order hierarchy and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 9, 2023
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors d+

src/data/finset/pairwise.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 13, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 13, 2023
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 16, 2023
A few more lemmas about `finset.sup_indep` and `set.pairwise_disjoint`.
@bors
Copy link

bors bot commented Jun 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(order/sup_indep): More lemmas [Merged by Bors] - feat(order/sup_indep): More lemmas Jun 16, 2023
@bors bors bot closed this Jun 16, 2023
@bors bors bot deleted the sup_indep_prod branch June 16, 2023 11:48
YaelDillies added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 17, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 19, 2023
Match leanprover-community/mathlib#11932



Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
alexkeizer pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 22, 2023
Match leanprover-community/mathlib#11932



Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 23, 2023
Match leanprover-community/mathlib#11932



Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 25, 2023
Match leanprover-community/mathlib#11932



Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants