Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/algebra/module/locally_convex): local convexity is preserved by Inf and induced #12118

Closed
wants to merge 44 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Feb 18, 2022

I also generalized slightly locally_convex_space.of_bases and changed a Sort* to Type* in filter.has_basis_infi to correctly reflect the universe constraints.


Open in Gitpod

@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 20, 2022
@ADedecker ADedecker added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Mar 1, 2022
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 1, 2022
@urkud
Copy link
Member

urkud commented Jun 10, 2022

Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 10, 2022
bors bot pushed a commit that referenced this pull request Jun 10, 2022
…erved by `Inf` and `induced` (#12118)

I also generalized slightly `locally_convex_space.of_bases` and changed a `Sort*` to `Type*` in `filter.has_basis_infi` to correctly reflect the universe constraints.
@bors
Copy link

bors bot commented Jun 10, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 10, 2022
…erved by `Inf` and `induced` (#12118)

I also generalized slightly `locally_convex_space.of_bases` and changed a `Sort*` to `Type*` in `filter.has_basis_infi` to correctly reflect the universe constraints.
@bors
Copy link

bors bot commented Jun 10, 2022

Build failed:

@ADedecker
Copy link
Member Author

ADedecker commented Jun 11, 2022

bors r+
(I don't know if this will work...)

EDIT : It obviously doesn't, is there a way to ask bors to try again without being a maintainer ?

@bors
Copy link

bors bot commented Jun 11, 2022

🔒 Permission denied

Existing reviewers: click here to make ADedecker a reviewer

@PatrickMassot
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jun 11, 2022
…erved by `Inf` and `induced` (#12118)

I also generalized slightly `locally_convex_space.of_bases` and changed a `Sort*` to `Type*` in `filter.has_basis_infi` to correctly reflect the universe constraints.
@bors
Copy link

bors bot commented Jun 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/algebra/module/locally_convex): local convexity is preserved by Inf and induced [Merged by Bors] - feat(topology/algebra/module/locally_convex): local convexity is preserved by Inf and induced Jun 11, 2022
@bors bors bot closed this Jun 11, 2022
@bors bors bot deleted the AD_Inf_induced_lctvs branch June 11, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants