New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(topology/algebra/module/locally_convex): local convexity is preserved by Inf
and induced
#12118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity/mathlib into AD_top_lattice_algebra
ADedecker
added
awaiting-review
The author would like community review of the PR
and removed
WIP
Work in progress
labels
Feb 20, 2022
ADedecker
added
WIP
Work in progress
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 1, 2022
ADedecker
added
awaiting-review
The author would like community review of the PR
and removed
WIP
Work in progress
labels
Jun 1, 2022
urkud
reviewed
Jun 9, 2022
Thanks! |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Jun 10, 2022
bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2022
…erved by `Inf` and `induced` (#12118) I also generalized slightly `locally_convex_space.of_bases` and changed a `Sort*` to `Type*` in `filter.has_basis_infi` to correctly reflect the universe constraints.
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2022
…erved by `Inf` and `induced` (#12118) I also generalized slightly `locally_convex_space.of_bases` and changed a `Sort*` to `Type*` in `filter.has_basis_infi` to correctly reflect the universe constraints.
Build failed: |
bors r+ EDIT : It obviously doesn't, is there a way to ask bors to try again without being a maintainer ? |
🔒 Permission denied Existing reviewers: click here to make ADedecker a reviewer |
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 11, 2022
…erved by `Inf` and `induced` (#12118) I also generalized slightly `locally_convex_space.of_bases` and changed a `Sort*` to `Type*` in `filter.has_basis_infi` to correctly reflect the universe constraints.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(topology/algebra/module/locally_convex): local convexity is preserved by
[Merged by Bors] - feat(topology/algebra/module/locally_convex): local convexity is preserved by Jun 11, 2022
Inf
and induced
Inf
and induced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also generalized slightly
locally_convex_space.of_bases
and changed aSort*
toType*
infilter.has_basis_infi
to correctly reflect the universe constraints.