New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analysis/inner_product_space/sqrt): is_self_adjoint.sqrt
#12312
base: master
Are you sure you want to change the base?
Conversation
We define the square root of a self-adjoint operator `T` on a finite-dimensional inner product space `E` in terms of an orthonormal basis of eigenvectors for `T`. Once `analysis.inner_product_space.spectrum` contains spectral theory for bounded operators, we can generalize to bounded self-adjoint operators. In the meantime, this finite-dimensional result will be useful for polar and singular value decompositions.
I'm a bit reluctant to merge this, since we'll get a much more general construction allowing to do this soon(ish): the continuous functional calculus, which will let us apply continuous functions to elements of a C*-algebra. It might be OK as a temporary measure if it's really blocking things we want (do you have code that depends on this lined up?), but I'd like to avoid getting in too deep. |
I understand this reluctance given the bright functional future! I thought this might be a bit specific. We do have some code for polar decomposition & SVD that we're cleaning up and contributing that depends on this. I don't know how pressing our formulations of these are; we are most interested in the finite-dimensional situation, and so some of our code has needed generalization. Happy to clean it up to get it in, but also totally understand if it isn't helpful at this time. |
Independent of the point raised by @dupuisf, I'd like to suggest that if this construction is kept that it's proved in a more canonical way: you can use the splitting into eigenspaces (the "first version" of the spectral theorem in the current library) rather than the further splitting by choosing a subordinate basis for that eigenspace. |
@hparshall What do you think of Heather's comment above? |
This seems like a reasonable suggestion that I will follow up on. |
We define the square root of a self-adjoint operator
T
on afinite-dimensional inner product space
E
in terms of an orthonormalbasis of eigenvectors for
T
.Once
analysis.inner_product_space.spectrum
contains spectral theoryfor bounded operators, we can generalize to bounded self-adjoint
operators. In the meantime, this finite-dimensional result will be
useful for polar and singular value decompositions.
Co-authored-by: Daniel Packer