Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algebraic closure #1297

Closed
wants to merge 23 commits into from
Closed

Algebraic closure #1297

wants to merge 23 commits into from

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Aug 3, 2019

I define the algebraic closure, prove it is algebraically closed and define the homomorphism from an algebraic extension into the algebraic closure.


Algebraic closure PR. I have a skeleton of a proof with some self contained sorries (mainly proving various extensions are algebraic, and the existence of various homomorphisms).

I plan to add some more comments to explain properly the approach I took. Some of the names leave a bit to be desired as well. There are also lemmas that belong elsewhere.

There are a lot of instances in this file, that are irrelevant outside of this file. Is there an easy way to limit the scope of an instance to a file as opposed to a section?

Depends on #1296

ChrisHughes24 and others added 3 commits August 3, 2019 21:04
Now this works, and it didn't work previously even with `@`
```lean
structure alg_equiv (α β γ : Type*) [comm_ring α] [ring β] [ring γ]
  [algebra α β] [algebra α γ] extends alg_hom α β γ :=
```
@ChrisHughes24 ChrisHughes24 added the WIP Work in progress label Aug 3, 2019
@ChrisHughes24 ChrisHughes24 requested a review from a team as a code owner August 3, 2019 20:54
@khoek
Copy link
Collaborator

khoek commented Aug 27, 2019

$ lean --recursive --export=mathlib.txt src/
<unknown>:1:1: error: failed to expand macro

What an interesting error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants