Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(data/gaussian_int): speed up div and mod #1394

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Sep 3, 2019

avoid using int.cast, and use rat.of_int.

This sped up #eval (⟨1414,152⟩ : gaussian_int) % ⟨123,456⟩ from about 5 seconds to 2 milliseconds

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

avoid using `int.cast`, and use `rat.of_int`.

This sped up `#eval (⟨1414,152⟩ : gaussian_int) % ⟨123,456⟩` from about 5 seconds to 2 milliseconds
@ChrisHughes24 ChrisHughes24 requested a review from a team as a code owner September 3, 2019 17:33
@digama0 digama0 added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 3, 2019
@mergify mergify bot merged commit 4b6fcd9 into master Sep 3, 2019
@mergify mergify bot deleted the ChrisHughes24-patch-1 branch September 3, 2019 17:53
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
)

avoid using `int.cast`, and use `rat.of_int`.

This sped up `#eval (⟨1414,152⟩ : gaussian_int) % ⟨123,456⟩` from about 5 seconds to 2 milliseconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants