refactor(linear_algebra/clifford_algebra): relax typeclasses to semiring #14350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to eric-wieser/quadratic_form-semiring
…gebra/quadratic_form/basic` 150 lines seems worthy of its own file, especially if this grows `fun_like` boilerplate in future. No lemmas have been renamed or proofs changed.
… eric-wieser/quadratic_form-semiring
This moves the `fun_like` lemmas up to the top of the file next to the `coe_to_fun` instance, and condenses some sections containing only one lemma.
…ser/quadratic_form-semiring
…com/leanprover-community/mathlib into eric-wieser/quadratic_form-semiring
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
…tic_form-semiring
…tic_form-semiring
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
…d_algebra-semiring-redo
semorrison
added
the
too-late
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalization isn't motivated by any particular result or generalization in the literature; rather, it's motivated by allowing
exterior_algebra R Mto be redefined asclifford_algebra 0, as this prevents all the results having to be duplicated.See also #14819