Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analysis/analytic/isolated_zeros): principle of isolated zeros #14382

Closed
wants to merge 5 commits into from

Conversation

vbeffara
Copy link
Collaborator

This is a first step towards isolated zeros / analytic continuation for analytic functions in one variable. The proof is by induction in the order of the zero, which is perhaps not optimal but necessitated the least amount of additional API for power series in one variable.


Open in Gitpod

@vbeffara vbeffara requested review from urkud and sgouezel May 25, 2022 17:58
@vbeffara vbeffara added the awaiting-review The author would like community review of the PR label May 25, 2022
@vbeffara
Copy link
Collaborator Author

vbeffara commented Jun 1, 2022

Updated proof, with a more explicit argument (f z can be factored as (z - z0) ^ n * iterated_dslope f n)

@sgouezel
Copy link
Collaborator

sgouezel commented Jun 5, 2022

The linter is not happy. Can you fix it by adding the missing docstring?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 7, 2022
@vbeffara
Copy link
Collaborator Author

vbeffara commented Jun 7, 2022

That should do it. I'm not sure though whether this definition is strictly needed (which is why it did not have a docstring in the first place). I do believe that we need a way to state "this sequence is summable and its sum satisfies this relation" and that was my attempt to do that, but even if it serves the API should be fleshed out.

@vbeffara vbeffara added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 7, 2022

/-- The index of the first non-zero coefficient in `p`. -/
noncomputable def order (p : formal_multilinear_series 𝕜 𝕜 E) : with_top ℕ :=
by classical; exact dite (∀ n, p.coef n = 0) (λ _, ⊤) (λ h, nat.find (not_forall.mp h))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should have formal_multilinear_series.order for any multilinear series. Then you can prove that the sum of a series is its first term plus O(...). BTW, you can use supr or infi to define it without dite.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed it makes sense to generalize the definition to the general case, although I was a bit afraid of matching p.coef n = 0 with p n = 0.

Saying order := Inf { n | p n = 0 } means that the order of the zero series would be 0 rather than \top, but in retrospect I am leaning more and more towards this option.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it would make sense to have this for a general formal multilinear series. And having order 0 = 0 is probably easier to use, indeed. Would you agree to make this change (and move this definition to another file)?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 17, 2022
@vbeffara vbeffara closed this Aug 7, 2022
@vbeffara vbeffara deleted the VB_isolated branch September 13, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants