Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/order/with_zero): Add eq_one_of_mul_eq_one lemmas #15644

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(algebra/order/with_zero): Add eq_one_of_mul_eq_one lemmas #15644

wants to merge 1 commit into from

Conversation

Multramate
Copy link
Collaborator

Open in Gitpod

@Multramate Multramate added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 23, 2022
@Multramate Multramate force-pushed the linear_ordered_comm_group_with_zero.eq_one_of_mul_eq_one branch from cbc8d37 to 68c4894 Compare July 23, 2022 15:08
@Multramate Multramate removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 23, 2022
Vierkantor
Vierkantor approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 16, 2022
bors bot pushed a commit that referenced this pull request Aug 16, 2022
@Multramate
feat(algebra/order/with_zero): Add eq_one_of_mul_eq_one lemmas (#15644)
0d43cc6
@bors
Copy link

bors bot commented Aug 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/order/with_zero): Add eq_one_of_mul_eq_one lemmas [Merged by Bors] - feat(algebra/order/with_zero): Add eq_one_of_mul_eq_one lemmas Aug 16, 2022
@bors bors bot closed this Aug 16, 2022
@bors bors bot deleted the linear_ordered_comm_group_with_zero.eq_one_of_mul_eq_one branch August 16, 2022 13:24
@YaelDillies YaelDillies mentioned this pull request Aug 24, 2022
Closed
bors bot pushed a commit that referenced this pull request Aug 29, 2022
@YaelDillies
refactor(algebra/order/with_zero): Generalize lemmas (#16240)
31297bd 
Generalize the lemmas introduced in #15644 to monoids + covariant classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Multramate @Vierkantor @leanprover-community-bot-assistant