Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/homotopy/homotopy_group): group and comm_group instances for π_n #15681

Closed
wants to merge 109 commits into from

Conversation

ralvrz
Copy link
Collaborator

@ralvrz ralvrz commented Jul 25, 2022

This PR adds:

  • Group instance for π_(n+1)
  • Commutative group instance for π_(n+2)

port: leanprover-community/mathlib4#3874

Open in Gitpod

@alreadydone alreadydone added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 3, 2023
@alreadydone
Copy link
Collaborator

forgot to label it awaiting-review ... now the main file has been ported to mathlib4 apparently

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 5, 2023
bors bot pushed a commit that referenced this pull request Jun 5, 2023
…ances for `π_n` (#15681)

This PR adds:
- Group instance for `π_(n+1)`
- Commutative group instance for `π_(n+2)`



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@bors
Copy link

bors bot commented Jun 5, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(topology/homotopy/homotopy_group): group and comm_group instances for π_n [Merged by Bors] - feat(topology/homotopy/homotopy_group): group and comm_group instances for π_n Jun 5, 2023
@bors bors bot closed this Jun 5, 2023
@bors bors bot deleted the pi_n branch June 5, 2023 08:24
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 7, 2023
…3874)

just changing explicitness of one variable
leanprover-community/mathlib#15681



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@alreadydone alreadydone restored the pi_n branch June 10, 2023 03:26
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…eanprover-community#3874)

just changing explicitness of one variable
leanprover-community/mathlib#15681



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 14, 2023
)

Removed `diagonal` stuff which is no longer needed.



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
alexkeizer pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 22, 2023
)

Removed `diagonal` stuff which is no longer needed.



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 25, 2023
)

Removed `diagonal` stuff which is no longer needed.



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@YaelDillies YaelDillies deleted the pi_n branch November 18, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants