refactor(linear_algebra/smodeq): Relax smodeq to accept arbitrary add_subgroups. #15915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
erdOne
commented
Aug 7, 2022
erdOne
commented
alreadydone
reviewed
Aug 8, 2022
| @@ -14,66 +15,99 @@ import ring_theory.ideal.quotient | |||
| open submodule | |||
| open_locale polynomial | |||
|
|
|||
| variables {R : Type*} [ring R] | |||
| variables {M : Type*} [add_comm_group M] [module R M] (U U₁ U₂ : submodule R M) | |||
| variables {M X : Type*} [add_comm_group M] [set_like X M] [add_subgroup_class X M] (U U₁ U₂ : X) | |||
There was a problem hiding this comment.
Do you intentionally not generalize this to [add_group M]?
eric-wieser
reviewed
Aug 8, 2022
| def smodeq (x y : M) : Prop := | ||
| (submodule.quotient.mk x : M ⧸ U) = submodule.quotient.mk y |
There was a problem hiding this comment.
Another solution here would be to eliminate the distinction between submodule.quotient and add_subgroup.quotient; they're now defined in terms of each other which they didn't use to be.
Did you attempt that at all @Vierkantor?
There was a problem hiding this comment.
I think I tried that a while ago before the redefinition of the quotients, and it was quite a bit of straightforward work so not too bad if you have some time. We did get the ⧸ notation out of that attempt though.
|
Closed for now. Maybe revisit in mathlib4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.