-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(category_theory/limits/shapes): another prototype for special shapes #1622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typo-fix suggestions and a question.
`is_binary_product X Y P` asserts that there is an isomorphism of hom-spaces | ||
`(Q ⟶ P) ≅ (Q ⟶ X) × (Q ⟶ Y)`, natural in `Q`. | ||
-/ | ||
structure is_binary_product (X Y P : C) := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is certainly the more readable statement. But I wonder if taking the more inherently functorial approach would buy us something down the road. I.e. declare this to be an iso between yoneda.obj P
and the product of the yoneda functors of X
and Y
in the functor category. Of course the naturality part of that iso wouldn't break down so nicely into two parts, but maybe simp-lemma can take care of that.
Co-Authored-By: Johan Commelin <johan@commelin.net>
This is another attempt at defining a
is_binary_products
structure, and the conversions back and forth to the general setup.As an example of use, it allows setting up binary products in
Type
as:@rwbarton, could you have a look at some point?
I'm planning on redoing the existing construction in
category_theory/limits/shapes/binary_products.lean
of associators and unitors for binary products in this formalism, to test how it works.If this looks okay, we'll have to do some copy-and-paste for the all the other special shapes.