chore(data/real/nnreal): make real.to_nnreal computable
#16645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`max` is not computable due to the `linear_order` argument, but the defeq `sup` is.
eric-wieser
force-pushed
the
eric-wieser/computable-to_real
branch
from
fa6d0bc
to
75cfb66
Compare
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
eric-wieser
added
easy
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
YaelDillies
approved these changes
Sep 26, 2022
| @@ -119,7 +119,7 @@ protected def to_nnreal : ℝ≥0∞ → ℝ≥0 := with_top.untop' 0 | |||
| protected def to_real (a : ℝ≥0∞) : real := coe (a.to_nnreal) | |||
|
|
|||
| /-- `of_real x` returns `x` if it is nonnegative, `0` otherwise. -/ | |||
| protected noncomputable def of_real (r : real) : ℝ≥0∞ := coe (real.to_nnreal r) | |||
| protected def of_real (r : real) : ℝ≥0∞ := coe (real.to_nnreal r) | |||
There was a problem hiding this comment.
Unrelated to the PR but I can't not see it.
Suggested change
| protected def of_real (r : real) : ℝ≥0∞ := coe (real.to_nnreal r) | |
| protected def of_real (r : real) : ℝ≥0∞ := coe r.to_nnreal |
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
semorrison
added
the
too-late
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... Of course, maybe it would be better to fix
max