Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data/finsupp/basic): Lemmas regarding finsupp.filter #17012

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(data/finsupp/basic): Lemmas regarding finsupp.filter #17012

wants to merge 7 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Oct 16, 2022

Open in Gitpod

@erdOne erdOne added the awaiting-review The author would like community review of the PR label Oct 16, 2022
@eric-wieser eric-wieser self-requested a review October 31, 2022 00:09
@Vierkantor Vierkantor self-assigned this Dec 22, 2022
Vierkantor
Vierkantor approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 22, 2022
bors bot pushed a commit that referenced this pull request Dec 22, 2022
@erdOne
feat(data/finsupp/basic): Lemmas regarding finsupp.filter (#17012)
2b7f398 


Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 22, 2022

Build failed:

@Vierkantor
Copy link
Collaborator

bors d+

@bors
Copy link

bors bot commented Dec 22, 2022

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Dec 22, 2022
@eric-wieser eric-wieser added modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Feb 4, 2023
@semorrison semorrison added too-late This PR was ready too late for inclusion in mathlib3 awaiting-review The author would like community review of the PR not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 and removed delegated The PR author may merge after reviewing final suggestions. too-late This PR was ready too late for inclusion in mathlib3 labels Jul 16, 2023
@semorrison
Copy link
Collaborator

Given this had not had a green tick for the 6 months leading up to the cut-off, I think this should be too-late rather than not-too-late.

@semorrison semorrison added too-late This PR was ready too late for inclusion in mathlib3 and removed not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 labels Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees

@Vierkantor Vierkantor

Labels
awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. too-late This PR was ready too late for inclusion in mathlib3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erdOne @Vierkantor @semorrison @eric-wieser @leanprover-community-bot-assistant