feat(linear_algebra/matrix_group): introduce matrix_group and instances
#17608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstances introduce matrix_group typeclass add a coercion to GL and proof some lemmas about it add a function special which produce special subgroup of a matrix group provide GL, U, O, SL, SU, SO as instances of matrix_group
vasnesterov
added
awaiting-review
replace ```has_coe``` with ```has_coe_t``` set low priority to ```coe_is_monoid_hom_trans``` swap "special" and "examples" sections
format curly braces make all lines no longer than 100
|
I'm sorry, What item on https://leanprover-community.github.io/undergrad_todo are you claiming this solves, btw? I'm not sure |
YaelDillies
added
awaiting-author
semorrison
added
the
too-late
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce matrix_group typeclass
add a coercion to GL and proof some lemmas about it add a function special which produce special subgroup of a matrix group provide GL, U, O, SL, SU, SO as instances of matrix_group
It's my very first PR, so I'm super open to any criticism and suggestions (about github usage, Zulip usage, code style, proofs (I think sometimes they are much longer than they could be, actually I only know the basic tactics so far), naming and so on).