chore(data/finset/image): reduce imports #17886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negiizhao
added
awaiting-review
eric-wieser
reviewed
Dec 10, 2022
| @@ -405,16 +407,18 @@ end | |||
|
|
|||
| lemma mem_range_iff_mem_finset_range_of_mod_eq [decidable_eq α] {f : ℤ → α} {a : α} {n : ℕ} | |||
| (hn : 0 < n) (h : ∀ i, f (i % n) = f i) : | |||
| a ∈ set.range f ↔ a ∈ (finset.range n).image (λi, f i) := | |||
| suffices (∃ i, f (i % n) = a) ↔ ∃ i, i < n ∧ f ↑i = a, by simpa [h], | |||
There was a problem hiding this comment.
Does the old proof no longer work?
There was a problem hiding this comment.
Old proof needs some lemmas in data.int.order.basic.
There was a problem hiding this comment.
int.mod_nonneg and int.mod_lt_of_pos.
There was a problem hiding this comment.
I'm a little wary of this this split; those seem like pretty fundamental properties of mod, so I would prefer not to have to effectively reprove them to prove this lemma.
Can you split this into two PRs; one that moves the imports, and one that changes edit: thanks!int.order.basic to int.basic?
github-actions
bot
removed
the
awaiting-CI
eric-wieser
added
awaiting-author
negiizhao
added
awaiting-review
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
eric-wieser
changed the title
|
That doesn't really seem important. |
YaelDillies
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. It's not important. Just seems like it shouldn't depend on
data.int.order.basic.Maybe
int.mod_nonnegandint.mod_lt_of_posshould be moved to a more basic file?Zulip