Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deprecated): delete deprecated folder #18066

Closed
wants to merge 1 commit into from

Conversation

ChrisHughes24
Copy link
Member


Nothing depends on it any more, so I guess we can delete it.

Open in Gitpod

@ChrisHughes24 ChrisHughes24 added the awaiting-review The author would like community review of the PR label Jan 5, 2023
@YaelDillies
Copy link
Collaborator

I think it makes sense because even if we end up swapping back to unbundled morphisms in Lean 4, we won't reuse this material.

Note you will also need to delete test.import_order_timeout.

@kbuzzard
Copy link
Member

kbuzzard commented Jan 5, 2023

My understanding is that the idea was that "these are sometimes useful as structures" so we're not going to delete them, although the fact that we never use them is an indication that perhaps they're not as useful as we think.

@jcommelin
Copy link
Member

#13506

@semorrison semorrison added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
@ChrisHughes24 ChrisHughes24 deleted the delete-deprecated branch August 12, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review The author would like community review of the PR too-late This PR was ready too late for inclusion in mathlib3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants