Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move module below group_power in the import hierarchy #1866

Closed
urkud opened this issue Jan 8, 2020 · 2 comments
Closed

Move module below group_power in the import hierarchy #1866

urkud opened this issue Jan 8, 2020 · 2 comments
Labels
needs-refactor RFC Request for comment

Comments

@urkud
Copy link
Member

urkud commented Jan 8, 2020

This way add_monoid.smul and add_group.gsmul will become instance ... : semimodule nat M and instance ... : module int G, respectively. The main bonus of this approach is that we won't need separate simplification lemmas for these smuls.
@urkud urkud added RFC Request for comment needs-refactor labels Jan 8, 2020
@urkud
Copy link
Member Author

urkud commented Mar 9, 2020

I tried to implement this, but we can't define instance ... : semimodule nat M, because for a non-commutative M we don't have smul_add.

@urkud
Copy link
Member Author

urkud commented Nov 10, 2021

This was done some time ago.

@urkud urkud closed this as completed Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-refactor RFC Request for comment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@urkud