chore(algebra/ring/defs): backport reordering from #3840 #18967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-CI
github-actions
bot
added
the
modifies-synchronized-file
semorrison
commented
May 8, 2023
Comment on lines
+131
to
+132
| theorem bernoulli'_power_series_mul_exp_sub_one_aux (n : ℕ) : | ||
| ∑ (p : ℕ × ℕ) in antidiagonal n, bernoulli' p.fst / p.fst! * ((p.snd + 1) * p.snd!)⁻¹ = (n!)⁻¹ := |
There was a problem hiding this comment.
This is to resolve a timeout.
semorrison
commented
May 8, 2023
| @@ -143,8 +143,7 @@ lemma mul_poly_of_interest_aux2 (n : ℕ) : | |||
| (p ^ n * witt_mul p n : mv_polynomial (fin 2 × ℕ) ℤ) + witt_poly_prod_remainder p n = | |||
| witt_poly_prod p n := | |||
| begin | |||
| convert mul_poly_of_interest_aux1 p n, | |||
| rw [sum_range_succ, add_comm, nat.sub_self, pow_zero, pow_one], | |||
| rw [← mul_poly_of_interest_aux1 p n, sum_range_succ, add_comm, nat.sub_self, pow_zero, pow_one], | |||
There was a problem hiding this comment.
This was timing out, but the direct rw is fast.
eric-wieser
reviewed
May 8, 2023
| -- Backporting note: this used to extend `(A →L[𝕜] A) × (A →L[𝕜] A)` | ||
| -- rather than having fields `fst` and `snd`. | ||
| -- However the mathlib4 refactor https://github.com/leanprover-community/mathlib4/pull/3840 | ||
| -- when backported caused a timeout here. I don't understand why this timeout occurs, |
There was a problem hiding this comment.
I can have a look at this tomorrow
There was a problem hiding this comment.
Thanks. I'm not sure that it's actually any worse this way. In fact, a benefit of the refactor I was forced to do here is that the fields could be called L and R as originally intended!
|
!bench |
|
@sgouezel, we don't have |
github-actions
bot
removed
the
awaiting-CI
semorrison
added
the
awaiting-review
eric-wieser
added
the
not-too-late
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sanity check for leanprover-community/mathlib4#3840.