Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Topology, Uniform spaces & Reals #2

Closed
wants to merge 14 commits into from

Conversation

johoelzl
Copy link
Collaborator

@johoelzl johoelzl commented Jul 31, 2017

this is not finished yet I copied everything from my library_dev development and adapted it to changes like ^. to ., @[simp] lemma in one line, absolute imports...

This pull request adds a construction for the reals. The idea is to develop a topology library inclusive a formalization of uniform spaces and uniform completion.

I need to admit it is not clear if a lot of work is safed by using this approach, proofing that the field properties hold using Cauchy sequences in Isabelle is also quite short. Edit: But then we do not yet have any topological results on the reals in Isabelle at this point.

@gebner
Copy link
Member

gebner commented Jul 31, 2017

Sorry for asking this so late, but why does Prop have the Sierpinski topology (instead of the discrete one, for example)? From what I can tell this definition is only used in continuous_abs_rat.

@digama0
Copy link
Member

digama0 commented Jul 31, 2017

I have to say, I'm worried about the maintainability here. You have a lot of new definitions, and it's not clear to me how much is necessary for the goal, or even exactly what the goal is since obviously you can get to the reals directly with a lot less work.

Why is defined as a quotient? should already be separated, so that the setoid construction is trivial.

@avigad
Copy link
Collaborator

avigad commented Jul 31, 2017

@digama0 This should give us other useful constructions too, for little extra cost -- including the completion of an arbitrary metric space (and infrastructure to extend functions defined on the dense subsets), and (a generalization of) Lebesgue measure.

@digama0
Copy link
Member

digama0 commented Jul 31, 2017

I'm fine with this construction because of its side effects, as you say, but we should be clear about what exactly are the goal posts and target uses of this library. This should help with separating the material into appropriately sized chunks and reuse in other areas. Even if there is a completion framework here, if no one knows how to use it other than the author it's useless. I think it is best to merge it now and work on making it more accessible as time goes on.

@johoelzl johoelzl changed the title [WIP] Reals [WIP] Topology, Uniform spaces & Reals Jul 31, 2017
@johoelzl
Copy link
Collaborator Author

@gebner the Sierpinski topology allows us to express that a predicate is an open set: continuous p <-> open {x | p x}. There is currently no application of this (I think also not in continuous_abs_rat). Somehow it feels natural to use it for Prop and the discrete topology for bool.

@digama0 the Cauchy filters over rat are not separated, even as rat itself is separated. Hence the quotient over the separation relation. Alternatively, we could use the minimal Cauchy filters as completion. I chose the two-step construction, to introduce a general construction of separated uniform spaces. I guess a it would be a good idea to add a general construction of the quotient over Cauchy filters.

I can add some references and a rough idea how the completion process works. I also changed the title to emphasise that it is more about introducing topology than constructing the real numbers.

Currently the theories are very abstract, but in my experience this will be necessary anyway. When we introduce metric spaces we could derive more concrete theorems, but I'm not sure if this is really helpful.

@johoelzl johoelzl force-pushed the real branch 5 times, most recently from 10a6a37 to ccad89b Compare August 2, 2017 15:47
@johoelzl johoelzl closed this Aug 8, 2017
@johoelzl
Copy link
Collaborator Author

johoelzl commented Aug 8, 2017

I will reopen it when I'm finished with completeness and reorganized the real.lean file.

jcommelin added a commit that referenced this pull request May 28, 2019
fpvandoorn pushed a commit that referenced this pull request Aug 6, 2019
bors bot pushed a commit that referenced this pull request Apr 23, 2020
ericrbg added a commit that referenced this pull request Apr 21, 2021
vihdzp added a commit that referenced this pull request Dec 13, 2021
linesthatinterlace added a commit that referenced this pull request Jul 8, 2022
MadPidgeon added a commit that referenced this pull request Nov 18, 2022
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
loefflerd added a commit that referenced this pull request Jan 25, 2023
loefflerd added a commit that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants