-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Topology, Uniform spaces & Reals #2
Conversation
Sorry for asking this so late, but why does |
I have to say, I'm worried about the maintainability here. You have a lot of new definitions, and it's not clear to me how much is necessary for the goal, or even exactly what the goal is since obviously you can get to the reals directly with a lot less work. Why is |
@digama0 This should give us other useful constructions too, for little extra cost -- including the completion of an arbitrary metric space (and infrastructure to extend functions defined on the dense subsets), and (a generalization of) Lebesgue measure. |
I'm fine with this construction because of its side effects, as you say, but we should be clear about what exactly are the goal posts and target uses of this library. This should help with separating the material into appropriately sized chunks and reuse in other areas. Even if there is a completion framework here, if no one knows how to use it other than the author it's useless. I think it is best to merge it now and work on making it more accessible as time goes on. |
@gebner the Sierpinski topology allows us to express that a predicate is an open set: @digama0 the Cauchy filters over I can add some references and a rough idea how the completion process works. I also changed the title to emphasise that it is more about introducing topology than constructing the real numbers. Currently the theories are very abstract, but in my experience this will be necessary anyway. When we introduce metric spaces we could derive more concrete theorems, but I'm not sure if this is really helpful. |
10a6a37
to
ccad89b
Compare
I will reopen it when I'm finished with completeness and reorganized the |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
this is not finished yet I copied everything from my
library_dev
development and adapted it to changes like^.
to.
,@[simp] lemma
in one line, absolute imports...This pull request adds a construction for the reals. The idea is to develop a topology library inclusive a formalization of uniform spaces and uniform completion.
I need to admit it is not clear if a lot of work is safed by using this approach, proofing that the field properties hold using Cauchy sequences in Isabelle is also quite short. Edit: But then we do not yet have any topological results on the reals in Isabelle at this point.