[Merged by Bors] - fix(tactic/delta_instance): handle universe metavariables #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
approved these changes
Apr 20, 2020
| @@ -1805,6 +1817,7 @@ do new_decl_type ← declaration.type <$> get_decl new_decl_name, | |||
| (_, inst) ← solve_aux tgt | |||
| (intros >> reset_instance_cache >> delta_target [new_decl_name] >> apply_instance >> done), | |||
| inst ← instantiate_mvars inst, | |||
| inst ← replace_univ_metas_with_univ_params inst, | |||
There was a problem hiding this comment.
Do you know where the universe metavariables come from here?
There was a problem hiding this comment.
In my examples that provoked this PR, they were the morphism universe levels associated to a category instance. In particular, see the test case I added:
attribute [derive large_category] Monwhich used to fail with a "declaration has universe metavariables" type error.
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2020
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…-community#2463) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…-community#2463) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…-community#2463) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.