[Merged by Bors] - feat(*): several @[simp] lemmas
#2579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add an explicit instance for `submodule.has_coe_to_sort`. This way `rintro ⟨x, hx⟩` results in `(hx : x ∈ p)`.
jcommelin
approved these changes
May 1, 2020
| @@ -584,6 +584,14 @@ by simp [and_comm] | |||
| @[simp] theorem exists_eq_right {a' : α} : (∃ a, p a ∧ a = a') ↔ p a' := | |||
| (exists_congr $ by exact λ a, and.comm).trans exists_eq_left | |||
|
|
|||
| @[simp] theorem exists_exists_and_eq_and {f : α → β} {p : α → Prop} {q : β → Prop} : | |||
There was a problem hiding this comment.
I can imagine that there are 37 permutations of these lemmas, but maybe these two are the only ones that typically show up in a "simp-path"...
There was a problem hiding this comment.
These two come from ∃ y ∈ f '' s and ∃ y ∈ set.range f.
github-actions
bot
added
the
ready-to-merge
|
Build failed: |
urkud
removed
the
ready-to-merge
|
bors r- |
|
Build fails because of mid-proof |
Comment on lines
+485
to
+486
| | left := ↑(λ n : ℕ, n.unpair.1) | ||
| | right := ↑(λ n : ℕ, n.unpair.2) |
There was a problem hiding this comment.
There's a very similar timeout issue here: https://github.com/leanprover-community/mathlib/blob/master/src/computability/partrec.lean#L149
There was a problem hiding this comment.
Do you have an idea why this became an issue after #2363? It was ~1s before and ~70s after.
There was a problem hiding this comment.
Unfortunately, no. Have you looked at type class search traces before and after?
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 2, 2020
Also add an explicit instance for `submodule.has_coe_to_sort`. This way `rintro ⟨x, hx⟩` results in `(hx : x ∈ p)`. Also fixes some timeouts introduced by #2363. See Zulip: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/partrec_code
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
@[simp] lemmas@[simp] lemmas
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
Also add an explicit instance for `submodule.has_coe_to_sort`. This way `rintro ⟨x, hx⟩` results in `(hx : x ∈ p)`. Also fixes some timeouts introduced by leanprover-community#2363. See Zulip: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/partrec_code
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
Also add an explicit instance for `submodule.has_coe_to_sort`. This way `rintro ⟨x, hx⟩` results in `(hx : x ∈ p)`. Also fixes some timeouts introduced by leanprover-community#2363. See Zulip: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/partrec_code
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
Also add an explicit instance for `submodule.has_coe_to_sort`. This way `rintro ⟨x, hx⟩` results in `(hx : x ∈ p)`. Also fixes some timeouts introduced by leanprover-community#2363. See Zulip: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/partrec_code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add an explicit instance for
submodule.has_coe_to_sort.This way
rintro ⟨x, hx⟩results in(hx : x ∈ p).Also fixes some timeouts introduced by #2363. See Zulip: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/partrec_code