Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat/cast): nat.cast_with_bot #2636

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(data/nat/cast): nat.cast_with_bot #2636

wants to merge 2 commits into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented May 9, 2020

kbuzzard
kbuzzard reviewed May 9, 2020
View reviewed changes
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need some kind of norm_cast tag or not?

@digama0
Copy link
Member Author

digama0 commented May 9, 2020

norm_cast doesn't like it because there is a cast on both sides. I think all the other attributes are gone

@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 9, 2020
bors bot pushed a commit that referenced this pull request May 9, 2020
@digama0
feat(data/nat/cast): nat.cast_with_bot (#2636)
96efc22 
As requested on Zulip: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/with_bot/near/196979007
@gebner
Copy link
Member

gebner commented May 9, 2020

norm_cast doesn't like it because there is a cast on both sides. I think all the other attributes are gone

@robertylewis Do you think this should become a @[norm_cast squash]?

@bors
Copy link

bors bot commented May 9, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/cast): nat.cast_with_bot [Merged by Bors] - feat(data/nat/cast): nat.cast_with_bot May 9, 2020
@bors bors bot closed this May 9, 2020
@bors bors bot deleted the cast_with_bot branch May 9, 2020 11:15
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@digama0 @anrddh
feat(data/nat/cast): nat.cast_with_bot (leanprover-community#2636)
abe69e8 
As requested on Zulip: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/with_bot/near/196979007
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
@digama0 @anrddh
feat(data/nat/cast): nat.cast_with_bot (leanprover-community#2636)
f468fe2 
As requested on Zulip: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/with_bot/near/196979007
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@digama0 @cipher1024
feat(data/nat/cast): nat.cast_with_bot (leanprover-community#2636)
37b16b8 
As requested on Zulip: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/with_bot/near/196979007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbuzzard kbuzzard kbuzzard left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@digama0 @ChrisHughes24 @gebner @kbuzzard