Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name clashes #27

Merged
merged 2 commits into from Dec 11, 2017
Merged

Name clashes #27

merged 2 commits into from Dec 11, 2017

Conversation

gebner
Copy link
Member

@gebner gebner commented Dec 11, 2017

We currently have two top-level definitions with the name embedding: one for cardinals, and another one for topological spaces. This causes problems if you want to import both, or use lean --recursive --export=mathlib.txt for the reference type checkers.

I put the cardinal embedding into the cardinal namespace. The topological embedding should probably also be namespaced, but I don't see an obvious candidate.

@digama0 digama0 merged commit 6b10d8d into leanprover-community:master Dec 11, 2017
@digama0
Copy link
Member

digama0 commented Dec 11, 2017

Do you know a way to work this into the Travis testing? That is, importing everything into the same file and seeing if it compiles?

@gebner
Copy link
Member Author

gebner commented Dec 11, 2017

That would work, but requires maintenance. We could also use lean --recursive --export=mathlib.txt, but that will break on sorry.

@Kha
Copy link
Collaborator

Kha commented Dec 11, 2017

You could --make that single file, then check whether that created all .olean files. The only thing missing is leanpkg clean... :)

@digama0
Copy link
Member

digama0 commented Dec 11, 2017

I'm okay with "break on sorry", I keep mathlib sorry-free anyway.

@digama0
Copy link
Member

digama0 commented Dec 11, 2017

Does lean --recursive --export do the same as find -name *.lean? I don't want to maintain a file with the list, but it should not be difficult to just scan the whole folder for lean files - there are no files we need to avoid.

@gebner
Copy link
Member Author

gebner commented Dec 11, 2017

Yes, lean --recursive --export=mathlib.txt recursively traverses the directory. It uses the same code as lean --make.

gebner added a commit to gebner/mathlib that referenced this pull request Dec 11, 2017
This should detect multiple definitions with the same name as in leanprover-community#27.
johoelzl pushed a commit that referenced this pull request Dec 14, 2017
This should detect multiple definitions with the same name as in #27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants