Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/projection): projection to a subspace #2739

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 19, 2020

Define equivalence between complement subspaces and projections.

Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me.

src/linear_algebra/projection.lean Outdated Show resolved Hide resolved
@robertylewis robertylewis added the awaiting-review The author would like community review of the PR label May 19, 2020
@sgouezel
Copy link
Collaborator

This is good for me, but I will leave some time for others to comment before merging it, as this is a nontrivial PR.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/linear_algebra/projection.lean Show resolved Hide resolved
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 20, 2020
bors bot pushed a commit that referenced this pull request May 20, 2020
Define equivalence between complement subspaces and projections.
@bors
Copy link

bors bot commented May 20, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/projection): projection to a subspace [Merged by Bors] - feat(linear_algebra/projection): projection to a subspace May 20, 2020
@bors bors bot closed this May 20, 2020
@bors bors bot deleted the projection branch May 20, 2020 07:49
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…-community#2739)

Define equivalence between complement subspaces and projections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants