Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(order/bounds): ⨆ i, f i + g i ≤ ⨆ i, f i + ⨆ i, g i #3001

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 9, 2020

We formulate this fact using is_lub because there is no typeclass
extending both ordered_add_comm_monoid and
complete_lattice.


We formulate this fact using `is_lub` because there is no typeclass
extending both `ordered_cancel_add_comm_monoid` and
`complete_lattice`.
@sgouezel
Copy link
Collaborator

sgouezel commented Jun 9, 2020

I am afraid this formulation will not be as easy to use as it should be in the cases of interest (say ennreal). Can't you introduce a suitable typeclass making it possible to formalize it in a clean way?

(In the long run, I think it would be better to disentangle our typeclass hierarchy, by having a main hierarchy for algebra, a main hierarchy for orders, and then mixins saying how the two interact, but I remember a discussion on Zulip with Mario where he said he preferred to have zillions of classes, for a reason I didn't really get).

@urkud
Copy link
Member Author

urkud commented Jun 9, 2020

Which typeclass are you talking about? Just add_le_add?

Another way is to drop the lemmas and use the one-line proofs.

@sgouezel
Copy link
Collaborator

sgouezel commented Jun 9, 2020

Depends on what you want to do with it. If you want to apply it in a typeclass extending ordered_add_comm_monoid and complete_lattice, then you can define such a typeclass, and show that the examples that are interesting to you are instances.

@bryangingechen bryangingechen added the awaiting-review The author would like community review of the PR label Jun 10, 2020
@urkud urkud closed this Jun 23, 2020
@urkud urkud deleted the supr-add-le branch July 20, 2020 15:36
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants