Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(measure_theory): make volume a bundled measure #3075

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - refactor(measure_theory): make volume a bundled measure #3075

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 14, 2020

This way we can apply and rw lemmas about measures without
introducing a volume-specific version.

@urkud
refactor(measure_theory): make volume a bundled measure
9a488e7 
This way we can `apply` and `rw` lemmas about `measure`s without
introducing a `volume`-specific version.
@urkud urkud added awaiting-review The author would like community review of the PR WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Jun 14, 2020
@urkud urkud mentioned this pull request Jun 16, 2020
Closed
@urkud urkud added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 16, 2020
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 16, 2020
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 16, 2020
@sgouezel
Copy link
Collaborator

Looks good to me, modulo a minor comment.
bors d+

@bors
Copy link

bors bot commented Jun 17, 2020

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud
Copy link
Member Author

urkud commented Jun 17, 2020

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 17, 2020
bors bot pushed a commit that referenced this pull request Jun 17, 2020
@urkud
refactor(measure_theory): make volume a bundled measure (#3075)
48c4f40 
This way we can `apply` and `rw` lemmas about `measure`s without
introducing a `volume`-specific version.
@bors
Copy link

bors bot commented Jun 17, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(measure_theory): make volume a bundled measure [Merged by Bors] - refactor(measure_theory): make volume a bundled measure Jun 17, 2020
@bors bors bot closed this Jun 17, 2020
@bors bors bot deleted the bundled-volume branch June 17, 2020 19:57
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@urkud @cipher1024
refactor(measure_theory): make volume a bundled measure (leanprover…
434ad7f 
…-community#3075)

This way we can `apply` and `rw` lemmas about `measure`s without
introducing a `volume`-specific version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @sgouezel